Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of _WIN32_WINNT #14

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@SebastianMosiej
Copy link
Contributor

SebastianMosiej commented Apr 4, 2019

Compilation on Windows with MinGW gcc fails due to lack of _WIN32_WINNT defined.

Set default value of _WIN32_WINNT
Compilation on Windows with MinGW gcc fails due to lack of _WIN32_WINNT defined.

@Croydon Croydon self-requested a review Apr 4, 2019

@Croydon

This comment has been minimized.

Copy link
Member

Croydon commented Apr 4, 2019

Can you point me to some grpc file or documentation where this is getting explained/stated?

@Croydon Croydon changed the base branch from stable/1.17.2 to testing/1.17.2 Apr 4, 2019

@Croydon

Croydon approved these changes Apr 4, 2019

Copy link
Member

Croydon left a comment

LGTM

@Croydon Croydon merged commit 5346e23 into inexorgame:testing/1.17.2 Apr 4, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.