Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace DCHECK_NE to avoid errors with gcc 5.3 #253
added a commit
this pull request
Dec 16, 2015
Dec 16, 2015
Well, though I am usually all for brief variable names, we should reprase to something like "OpenGL related functionality failed".
We may also add a "TODO: Move to a better location", since util/ is a generic module and should not contain graphics related code. So, even though I recommend not adding code to engine/, some header in there might have been a good place for it since it's more on-topic there.
@koraa Since the pull request was around for some time I assumed that everyone has already seen it and had no objections. As I already mentioned, it’s mandatory for me to have this changes in master in order to compile inexor using gcc 5.3.
Also, I wouldn’t leave things being the second best solution. What file should I move the exception definition to?
@DarkDeepBlue Well, you pushed a new version this morning ^^
I suppose we could move the exception into engine/engine.hpp. This header is a bit problematic, but I think in this case this would be best.
Btw, I should also mention that I am very glad that we now support the most recent GCC. I am very glad GCC 5.3 is supported now and I just started my package manager.
As a talerted programmer noted a few days ago, the branch was actually updated and I myself witnessed that this very version full of awesomeness and joy was on Github since then.
It’s a nice thing that you can upgrade your system now. :)