Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi line arrays are not properly handled by code coverage #652

Closed
BackEndTea opened this issue Mar 6, 2019 · 1 comment · Fixed by #655
Closed

Multi line arrays are not properly handled by code coverage #652

BackEndTea opened this issue Mar 6, 2019 · 1 comment · Fixed by #655
Labels
Milestone

Comments

@BackEndTea
Copy link
Member

BackEndTea commented Mar 6, 2019

Is your feature request related to a problem? Please describe.
With #649, we will see a lot more mutations of arrays. And multi-line arrays aren't properly handled
by code coverage, as seen in #214.

Describe the solution you'd like
This is gonna be a bit difficult, as PHPDBG and Xdebug both take a different approach on array coverage. But the best solution (i think) would be to check if either the first item, or the opening bracket is considered covered, and then use that for the rest of the array as well.

Describe alternatives you've considered
As it stands, #649 will cause a lot of un-killable mutations, which is something we'd like to avoid.

@BackEndTea BackEndTea changed the title Multi line array Multi line arrays are not properly handled by code coverage Mar 6, 2019
@sanmai
Copy link
Member

sanmai commented Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants