Conversation
sidz
commented
Oct 29, 2020
| PHP | ||
| ]; | ||
|
|
||
| if (PHP_VERSION_ID < 80000) { |
Member
Author
There was a problem hiding this comment.
PrettyPrinter from PhpParser generates nested ternary operators instead of wrap them up in braces. Fixed in nikic/PHP-Parser@eff72ee and hope will be in the next release so we will be able to remove this condition.
Nested ternary is deprecated since 7.4 and dropped in 8.0
sanmai
approved these changes
Oct 30, 2020
a536942 to
78f662c
Compare
sidz
added a commit
to infection/site
that referenced
this pull request
Oct 30, 2020
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Mutates: