Merged
Conversation
maks-rafalko
commented
Dec 7, 2020
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <files psalm-version="4.1.1@16bfbd9224698bd738c665f33039fade2a1a3977"> | ||
| <file src="src/Mutator/Regex/PregMatchRemoveCaret.php"> | ||
| <ImpureFunctionCall occurrences="1"> |
Member
Author
There was a problem hiding this comment.
Unfortunately, thecodingmachine/safe package does not support Psalm's annotations yet, and functions are missing @pure annotation, that's why we have issues reported by Psalm.
Tried https://github.com/hectorj/safe-php-psalm-plugin, but it doesn't work properly, so for now it's ok to suppress them
…dd support for all possible delimiters
…upport psalm annotations yet thecodingmachine/safe#141
4ef0d13 to
d0dd870
Compare
maks-rafalko
added a commit
to infection/site
that referenced
this pull request
Dec 8, 2020
BackEndTea
reviewed
Dec 8, 2020
Member
Author
|
Thank you @BackEndTea |
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a rebirth of #388
Fixes #324
2 new mutations here:
Other possible mutations will be done in a separate PRs after this one is merged.