Add support for @infection-ignore-all annotation#1468
Merged
sanmai merged 11 commits intoinfection:masterfrom Jan 12, 2021
Merged
Add support for @infection-ignore-all annotation#1468sanmai merged 11 commits intoinfection:masterfrom
@infection-ignore-all annotation#1468sanmai merged 11 commits intoinfection:masterfrom
Conversation
3 tasks
Member
|
LGTM |
Member
Author
|
@maks-rafalko This should auto-merge upon approval. |
maks-rafalko
approved these changes
Jan 11, 2021
Member
maks-rafalko
left a comment
There was a problem hiding this comment.
👍
let's see how automerging works
Member
Member
Author
|
Can't get it working too. |
Member
|
@sanmai are you able to create a PR for docs please? |
Member
Author
|
Where do you think will be the best place to put it? |
Member
|
Probably, somewhere in the Usage article. There we have information about other annotations like |
Member
Author
|
I'm not exactly sure these |
sanmai
added a commit
to sanmai/infection
that referenced
this pull request
May 4, 2021
4 tasks
sanmai
added a commit
that referenced
this pull request
May 4, 2021
Since we have a very explicit annotation `@infection-ignore-all` (added in #1468) that, again, very explicit on the purpose, and works not only for methods, but for most kinds of statements, let's remove `@codeCoverageIgnore` ignorer, that not only implicit (you may only want to ignore a piece of code temporarily, and only ignore) but also messes up the metrics (hides otherwise-uncovered mutations).
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See #1231
This PR:
@infection-ignore-allGive this example Infection won't mutate or even look at anything inside this function:
Likewise, given this annotation Infection won't consider anything in this loop: