You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the light of #1430 it doesn't make sense to keep Infection suggesting logging at all times. Keeping old behavior will mean that Infection will use 66% more memory where it could not.
This PR:
Updates configuration master to do not log by default.
I wonder if it's wise though: when you kill everything that's all good but as soon as you got one, then what? You need to run infection again with a log file this time
Ah I see. Still it's not the default this may just lead to very confused users. What do you think of enabling --show-mutations automatically there is no log file?
This also be confusing, e.g. when a user expects --show-mutations to be enabled automatically, adds a log file, and sees it no longer enabled without clear reason. This can be alleviated by a adding a note in the output, but then we could consider other similar ways. For example:
We could add "Tip: to show escaped mutations run Infection with --show-mutations" somewhere after the results.
We could have --show-mutations enabled at all times unconditionally, but showing it above metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the light of #1430 it doesn't make sense to keep Infection suggesting logging at all times. Keeping old behavior will mean that Infection will use 66% more memory where it could not.
This PR: