fix: Do not increment max integer value (fixes #1484)#1486
Merged
sanmai merged 1 commit intoinfection:masterfrom Feb 22, 2021
DeepDiver1975:fix/max-int-value-increment
Merged
fix: Do not increment max integer value (fixes #1484)#1486sanmai merged 1 commit intoinfection:masterfrom DeepDiver1975:fix/max-int-value-increment
sanmai merged 1 commit intoinfection:masterfrom
DeepDiver1975:fix/max-int-value-increment
Conversation
maks-rafalko
approved these changes
Feb 22, 2021
Member
maks-rafalko
left a comment
maks-rafalko
left a comment
There was a problem hiding this comment.
Looks good to me.
Could you please run make cs to fix style issues?
Contributor
Author
I tried .... see #1487 ;-) |
Member
|
Thank you @DeepDiver1975 |
maks-rafalko
pushed a commit
that referenced
this pull request
Feb 22, 2021
Contributor
|
The test won't work on a 32-bit system, will it? |
Member
Looks like yes, see #1490 |
1 task
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes #1484