pcov.directory autodetection#1499
Merged
sanmai merged 3 commits intoinfection:masterfrom Mar 21, 2021
Merged
Conversation
sanmai
force-pushed
the
pr/pcov-directory-auto
branch
from
9b8400a to
28e0f5f
Compare
sanmai
force-pushed
the
pr/pcov-directory-auto
branch
from
28e0f5f to
f25532a
Compare
sanmai
force-pushed
the
pr/pcov-directory-auto
branch
3 times, most recently
from
c07c7cb to
7f9e028
Compare
sanmai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
pcov.directoryautodetectionNote an E2E tests that files on current Infection: f25532a
If PCOV sees any of the directories, and if it wasn't told otherwise, it would just use first of them.
E.g. if a project has both
liba andapp, only the first fill be used for coverage, and the other will have 0% coverage. We work around this by forcing not-so-clever default value of.i.e. current working directory if we don't seepcov.directoryset to something more specific.Future step would be to set
pcov.directoryto a specific value inferred from the configuration.