Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement UnwrapArrayUintersectAssoc mutator #628

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 12, 2019

This PR

Related to #514.

💁‍♂️ Follows the example in #513.

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Feb 13, 2019
@maks-rafalko maks-rafalko mentioned this pull request Feb 13, 2019
46 tasks

protected function getParameterIndexes(Node $node): \Generator
{
yield 0;
Copy link
Member

@maks-rafalko maks-rafalko Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be

yield from \array_slice(
    array_keys($node->args),
    0,
    \count($node->args) - 1
);

as in array_intersect_uassoc? https://github.com/infection/infection/pull/591/files#diff-476671cc348930680a7c09fe701c7ffaR52

Copy link
Member Author

@localheinz localheinz Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm not sure anymore about some of the other mutators, maybe we should adjust them as well?

Copy link
Member

@maks-rafalko maks-rafalko Feb 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any particular mutator in mind?

Copy link
Member Author

@localheinz localheinz Feb 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll take a closer look later!

@localheinz localheinz force-pushed the feature/unwrap-array-uintersect-assoc branch from e346f74 to 589da0b Compare Feb 13, 2019
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Thank you @localheinz

@maks-rafalko maks-rafalko merged commit e2fdecc into infection:master Feb 15, 2019
5 checks passed
@localheinz localheinz deleted the feature/unwrap-array-uintersect-assoc branch Feb 15, 2019
@localheinz
Copy link
Member Author

localheinz commented Feb 15, 2019

Thank you, @borNfreee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants