Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Normalize composer.json #629

Merged
merged 1 commit into from Feb 13, 2019

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 12, 2019

This PR

  • normalizes composer.json

πŸ’β€β™‚οΈ I ran

$ composer global require localheinz/composer-normalize

followed by

$ composer normalize

For reference, see https://github.com/localheinz/composer-normalize.

sanmai
sanmai previously approved these changes Feb 13, 2019
@sanmai
Copy link
Member

sanmai commented Feb 13, 2019

Builds are failing with...

The minimum required MSI percentage should be 90%, but actual is 79%.

There's an explanation in #627. Should not be an issue for this PR.

maks-rafalko
maks-rafalko previously approved these changes Feb 13, 2019
@maks-rafalko
Copy link
Member

maks-rafalko commented Feb 13, 2019

could you please resolve conflict with composer.lock?

@localheinz localheinz dismissed stale reviews from maks-rafalko and sanmai via 0d27cfe Feb 13, 2019
@maks-rafalko
Copy link
Member

maks-rafalko commented Feb 13, 2019

Thank you @localheinz

@maks-rafalko maks-rafalko merged commit 8d7b5f3 into infection:master Feb 13, 2019
2 of 3 checks passed
@localheinz localheinz deleted the feature/normalize branch Feb 13, 2019
@localheinz
Copy link
Member Author

localheinz commented Feb 13, 2019

Thank you, @borNfreee and @sanmai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants