Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement UnwrapArrayUintersectUassoc mutator #633

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 16, 2019

This PR

Related to #514.

💁‍♂️ Follows the example in #513.

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Feb 16, 2019
@maks-rafalko maks-rafalko mentioned this pull request Feb 16, 2019
46 tasks

protected function getParameterIndexes(Node $node): \Generator
{
yield 0;
Copy link
Member

@maks-rafalko maks-rafalko Feb 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as for array_uintersect_assoc (actually, this is almost the same function).

Shouldn't we yield N mutations?

@localheinz localheinz force-pushed the feature/unwrap-array-uintersect-uassoc branch from fae5b4d to c9c83aa Compare Feb 16, 2019
@localheinz localheinz force-pushed the feature/unwrap-array-uintersect-uassoc branch from c9c83aa to 64d2074 Compare Feb 17, 2019
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Thank you @localheinz

@maks-rafalko maks-rafalko merged commit 08f9c20 into infection:master Feb 17, 2019
5 checks passed
@localheinz localheinz deleted the feature/unwrap-array-uintersect-uassoc branch Mar 23, 2019
@localheinz
Copy link
Member Author

localheinz commented Mar 23, 2019

Thank you, @borNfreee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants