Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more count esque functions to not decrement against #640

Merged

Conversation

BackEndTea
Copy link
Member

@BackEndTea BackEndTea commented Feb 17, 2019

They dont need decrementing for the same reason as count functions.

Copy link

@tests-checker tests-checker bot left a comment

Thank you for contributing to Infection. We noticed you didn't add any tests. Could you please add them to make sure everything works as expected?

maks-rafalko
maks-rafalko previously approved these changes Feb 17, 2019
Copy link
Member

@maks-rafalko maks-rafalko left a comment

👍

It would be nice to add tests for new functions as well. At least mutant won't be killed when we implement this mutator #597, which is not a good thing

localheinz
localheinz previously approved these changes Feb 17, 2019
Copy link
Member

@localheinz localheinz left a comment

👍

@@ -44,7 +44,7 @@
*/
final class DecrementInteger extends Mutator
{
private const COUNT_NAMES = ['count', 'sizeof'];
private const COUNT_NAMES = ['count', 'grapheme_strlen', 'iconv_strlen', 'mb_strlen', 'sizeof', 'strlen'];
Copy link
Member

@localheinz localheinz Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about starting to wrap here sooner or later?

sanmai
sanmai previously approved these changes Feb 18, 2019
BackEndTea added 3 commits Mar 8, 2019
They dont need decrementing for the same reason as count functions.
@BackEndTea BackEndTea dismissed stale reviews from maks-rafalko, sanmai, and localheinz via c1ba65e Mar 8, 2019
@BackEndTea BackEndTea force-pushed the enhancement/add-more-count-like branch from 74d1ec3 to c1ba65e Compare Mar 8, 2019
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Thank you @BackEndTea

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Mar 9, 2019
@maks-rafalko maks-rafalko merged commit 46c0533 into infection:master Mar 9, 2019
5 checks passed
@BackEndTea
Copy link
Member Author

BackEndTea commented Mar 9, 2019

Thank you @borNfreee, @sanmai & @localheinz

@BackEndTea BackEndTea deleted the enhancement/add-more-count-like branch Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants