Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutator: AssignCoalesce. Upgrade PHPParser to 4.2.1 #641

Merged
merged 3 commits into from Feb 18, 2019

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Feb 17, 2019

This PR:

See https://wiki.php.net/rfc/null_coalesce_equal_operator

Produces the following mutation:

- $this->request->data['comments']['user_id'] ??= 'value';
+ $this->request->data['comments']['user_id'] = 'value';

localheinz
localheinz previously approved these changes Feb 17, 2019
Copy link
Member

@localheinz localheinz left a comment

👍

composer.json Outdated Show resolved Hide resolved
sanmai
sanmai previously approved these changes Feb 18, 2019
@maks-rafalko
Copy link
Member Author

maks-rafalko commented Feb 18, 2019

Thank you @sanmai, @localheinz and @BackEndTea

@maks-rafalko maks-rafalko merged commit 5f162ef into master Feb 18, 2019
4 of 5 checks passed
@maks-rafalko maks-rafalko deleted the null-coalesce-mutator branch Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants