Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#597 Array item removal mutator #649

Merged

Conversation

majkel89
Copy link
Contributor

@majkel89 majkel89 commented Mar 3, 2019

This PR:

Fixes #597

@majkel89 majkel89 marked this pull request as ready for review Mar 3, 2019
maks-rafalko
maks-rafalko previously approved these changes Mar 4, 2019
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Thanks for creating this mutator!

Added a couple of comments. Also, documentation PR should be opened in infection/site repo.

src/Mutator/Removal/ArrayItemRemoval.php Outdated Show resolved Hide resolved
src/Mutator/Removal/ArrayItemRemoval.php Show resolved Hide resolved
@majkel89
Copy link
Contributor Author

majkel89 commented Mar 5, 2019

PR for doc already provided

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Mar 6, 2019
BackEndTea
BackEndTea previously approved these changes Mar 6, 2019
Copy link
Member

@BackEndTea BackEndTea left a comment

👍 Besides the few comments i had, this is a great PR, and the configuration has sane defaults.

@maks-rafalko
Copy link
Member

maks-rafalko commented Mar 8, 2019

Build is failing

@majkel89
Copy link
Contributor Author

majkel89 commented Mar 8, 2019

Build has been fixed

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Thank you @majkel89 👍

@maks-rafalko maks-rafalko merged commit cf8c3c5 into infection:master Mar 9, 2019
5 checks passed
@ghost ghost removed the Needs Review label Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants