Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parent array for coverage #655

Merged

Conversation

BackEndTea
Copy link
Member

@BackEndTea BackEndTea commented Mar 8, 2019

This PR:

  • Handles array coverage a bit better
  • Covered by tests

As shown here, array coverage is a bit wonky, and not all items are considered covered, except if function/methods are called as part of the array.
This PR should make sure that any array is properly covered.
image

It isn't properly tested, as the MutationsCollectorVisitor is a bit complex. I'll create a separate PR, to fix that up later.

Fixes #652

@maks-rafalko maks-rafalko self-requested a review Mar 9, 2019
@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Mar 9, 2019
@sanmai sanmai added the bugfix label Mar 9, 2019
maks-rafalko
maks-rafalko previously approved these changes Mar 29, 2019
Copy link
Member

@maks-rafalko maks-rafalko left a comment

LGTM

@maks-rafalko
Copy link
Member

maks-rafalko commented Mar 31, 2019

could you please rebase on master?

@BackEndTea
Copy link
Member Author

BackEndTea commented Apr 24, 2019

Appveyor failure is due to a http request failing for schema validation.
Travis failures are due to minimum MSI.

Copy link
Member

@maks-rafalko maks-rafalko left a comment

👍 Thank you @BackEndTea

@maks-rafalko maks-rafalko merged commit 70371dd into infection:master Apr 24, 2019
1 of 3 checks passed
@ghost ghost removed the Needs Review label Apr 24, 2019
@BackEndTea BackEndTea deleted the feature/better-array-coverage branch Apr 24, 2019
@BackEndTea
Copy link
Member Author

BackEndTea commented Apr 25, 2019

Thank you @borNfreee

@loic425
Copy link

loic425 commented Apr 25, 2019

@borNfreee Is there a new release with this bugfix planned soon?

@BackEndTea
Copy link
Member Author

BackEndTea commented Apr 25, 2019

Currently for the milestone there are 2 open issues #520 and #488. #488 already has a PR: #602.
#520 has a PR: #610, but im not sure what the status of that is.

So in essence those 2 have to be resolved, before 0.13.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants