Skip to content

Conversation

@edenreich
Copy link
Contributor

@edenreich edenreich commented Oct 14, 2025

Summary

Removes the specialized write_to_csv skill in favor of using ADK's built-in create_artifact tool. The take_screenshot skill now saves files locally and returns file paths instead of automatically creating artifacts. This promotes better separation of concerns - skills handle browser automation while the agent uses create_artifact for making files downloadable.

Changes

Removed

  • write_to_csv skill and all related tests (skills/write_to_csv.go, skills/write_to_csv_test.go)
  • Automatic artifact creation logic from take_screenshot skill

Modified

  • take_screenshot skill: Now saves screenshots to local filesystem and returns the file path instead of automatically creating artifacts
  • Agent system prompt: Updated to include instructions for using create_artifact tool with screenshots and data extraction
  • Main server initialization:
    • Changed from NewDefaultToolBox() to NewToolBox() + WithDefaultToolBox() pattern
    • Added ArtifactService initialization and configuration
    • Updated server builder to use WithArtifactService instead of WithArtifactStorage
  • Dependencies: Upgraded ADK from v0.14.0 to v0.15.0

Benefits

  • Better separation of concerns: Skills focus on their core functionality (browser automation), artifact creation is handled by the agent
  • More flexible: Users can choose whether to create artifacts or just work with local files
  • Reduced code duplication: Removes specialized artifact handling from individual skills
  • Consistent pattern: All file creation now follows the same pattern: skill creates file → agent uses create_artifact to make it downloadable

Test Plan

  • Removed tests for write_to_csv skill
  • Updated take_screenshot tests to validate file path return instead of artifact creation
  • Manual testing: Verify screenshots can be taken and then converted to artifacts using create_artifact tool
  • Manual testing: Verify data extraction → CSV conversion → artifact creation workflow

Migration Notes

For users upgrading to this version:

  • The write_to_csv skill is no longer available
  • To create CSV files, use data extraction combined with the create_artifact tool
  • Screenshots now return file paths; use create_artifact to make them downloadable

…apabilities for artifact creation

Signed-off-by: Eden Reich <eden.reich@gmail.com>
… multiple files

Signed-off-by: Eden Reich <eden.reich@gmail.com>
…tiple files; add A2A_AGENT_CLIENT_TOOLS_CREATE_ARTIFACT configuration

Signed-off-by: Eden Reich <eden.reich@gmail.com>
…se programmatically approach for this one

Sense the artifacts in this case created as screenshots already by playwright there i no need to send it over to the LLM and back to another tool in order to create it, this would be a waste of tokens.

Signed-off-by: Eden Reich <eden.reich@gmail.com>
@edenreich edenreich merged commit 144d901 into main Oct 14, 2025
1 check passed
@edenreich edenreich deleted the feature/remove-specialized-built-in-tool-from-skills branch October 14, 2025 17:30
ig-semantic-release-bot bot pushed a commit that referenced this pull request Oct 14, 2025
## [0.3.3](v0.3.2...v0.3.3) (2025-10-14)

### ♻️ Improvements

* Remove write_to_csv skill and related tests ([#36](#36)) ([144d901](144d901))
@ig-semantic-release-bot
Copy link

🎉 This PR is included in version 0.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants