Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

[Bug] /pass for deactivation, and possibly activation of the device is heard globally #5

Closed
ResqDiver1317 opened this issue Oct 22, 2019 · 2 comments
Assignees
Labels

Comments

@ResqDiver1317
Copy link

Describe the bug
Pretty much everytime (or at least everytime I'm actually watching chat) when one of us turns off our PASS device, we see messages in chat from people nowhere near us asking what that noise was. It doesn't seem to be an issue with stage 1 or stage 2 and I'm not 100% sure on the Activation as I'm not usually watching chat at this point as I'm trying to get geared up to go into the fire but almost every time we turn our devices off after we come out, we see messages in chat about it.
Steps to reproduce
We were working a fire at Yellowjack at Panorama and Route 68 and had 8 FFs all in the fire working it. As they made their way out and started turning off their PASS devices, there were people in Paleto Bay and Grapeseed asking in chat what all the beeping was about. We have had issues trying to determine if it is everytime or not as at this point, many of our players know what the sound is and just ignore it so when we have tried to test to see if anyone notices, we do not get questions everytime but moreoften than not, we will get people asking.
Expected behavior
Sound should only be heard in a relatively short radius as would be expected IRL.
Screenshots
If applicable, add screenshots to help explain your problem.

Resource version
1.2 Beta
Additional context
Add any other context about the problem here.

@ResqDiver1317 ResqDiver1317 added the Unconfirmed Bug A newly submitted bug that has yet to be reviewed label Oct 22, 2019
@cm8263
Copy link
Member

cm8263 commented Oct 22, 2019

This issues arrises from the way we handle (or perhaps more accurately, mishandle) the deactivation sound. While all other sounds that are played are able to use the volume loop, this one can not, because the sound is removed from the server table, and all client tables before the sound has a chance to be played. During early development, we resolved this issue by simply having it play full volume, and clearly we've forgotten about that and it's make it into the public release. This is a major oversight on our behalf, so apologies about that; we'll look into creating a fix for Version 1.31 which is due to release this weekend; in the meantime, my suggestion is to change this line to 0.0, which will remove the sound for everyone.

Thanks for pointing this out!

@cm8263 cm8263 added Bug A confirmed bug report and removed Unconfirmed Bug A newly submitted bug that has yet to be reviewed labels Oct 22, 2019
@cm8263 cm8263 added this to the Public Beta Version 1.3 milestone Oct 22, 2019
@cm8263 cm8263 pinned this issue Oct 22, 2019
@cm8263
Copy link
Member

cm8263 commented Oct 27, 2019

Fixed in 7ded8f2.

@cm8263 cm8263 closed this as completed Oct 27, 2019
@cm8263 cm8263 added Closed and removed Bug A confirmed bug report labels Oct 27, 2019
@cm8263 cm8263 unpinned this issue Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants