setState callbacks are sometimes not called

[larpo]

Like the tittle says, it seems that inferno (inferno-compat@1.0.7) loses setState callbacks occasionally. Not exactly sure what triggers the bug (setState from inside componentWillReceiveProps?). Anyway, in the snip below, the setState callback in inner component never gets executed.

class Outter extends Component {
    constructor(){
        super();
        this.state = {text: "initial text"};
    }

    doStuff(){
        this.setState({text: "editex text"}, function(){
            console.log("called back from doStuff")
        });
    }
    componentDidMount(){
        setTimeout(()=> this.doStuff(), 1000);
    }

    render(){
        return <Inner txt={this.state.text}></Inner>;
    }
}

class Inner extends Component {
    constructor(props){
        super(props);
        this.state = {dirty: false, callback: false};
    }

    componentWillReceiveProps(nextProps) {
        if (nextProps.txt != this.props.txt) {
            this.setState({dirty: true}, () => {
              console.log("this get never called!")
              this.setState({callback: true});
           });
        }
    }
		
    render(){
        return <div>
          <p>{this.props.txt}</p>
          <p>callback called: {this.state.callback? "yes": "no"}</p>
          <p>dirty:  {this.state.dirty? "yes": "no"}</p>
        </div>;
    }
}

Made a jsfiddle out of it: https://jsfiddle.net/9fg6sxjk/9/
Notice how the state.callback never changes to "yes" and the later console log doesn't appear on console.

[Havunen]

I have verified this is indeed bug, I hope dominic could take a look. ping @trueadm

[lukeed]

Verified as well, even after fixing the componentWillReceiveProps body. It should be this:

this.setState({dirty: true}, () => {
  console.log("this get never called!")
  this.setState({callback: true});
});

This is because (1) props.text never changes in this fiddle and (2) the last this.setState lost its parent context.

[larpo]

@lukeed oops, good catch! I'll update the fiddle so that it won't confuse ppl...

[trueadm]

I'll look into this one tomorrow if I get time. Some RL stuff to deal with this weekend!