Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render property 'selectedIndex' as attribute of element 'select' when this option passed #1468

Merged
merged 1 commit into from Apr 24, 2019

Conversation

abaksha-sc
Copy link
Contributor

@abaksha-sc abaksha-sc commented Apr 24, 2019

Before submitting a PR please:

  • Include tests for the functionality you are adding! See CONTRIBUTING.md for details how to run tests.
  • Run npm run build and check that the build succeeds.
  • Ensure that the PR hasn't been submitted before.

Problem: Attribute selectedIndex rendered into node select when this option passed. It's not needed

image

It was introduced here: #1425

To fix it added property selectedIndex to list of ignored properties of function patchProp

@abaksha-sc abaksha-sc marked this pull request as ready for review April 24, 2019 14:05
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 95.065% when pulling 5d90fcb on abaksha-sc:master into c339047 on infernojs:master.

@Havunen
Copy link
Member

Havunen commented Apr 24, 2019

Thanks for the PR! This change looks good to me :) lets merge it.

@Havunen Havunen merged commit 3e3bc4c into infernojs:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants