Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix performance bug inferno animation #1576

Merged

Conversation

jhsware
Copy link
Contributor

@jhsware jhsware commented Oct 25, 2021

There was a missing return in a switch statement that caused some dom setters to be run twice during animations. This was a performance bug but didn't change the behaviour as far as I can tell.

Also changed code in animationCoordinator.ts to make it more obvious what the code accomplishes.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.02%) to 93.076% when pulling 4014862 on jhsware:hotfix-performance-bug-inferno-animation into 7702509 on infernojs:master.

@Havunen Havunen merged commit dd1a574 into infernojs:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants