Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBuilder should respect @JacksonXmlProperty annotations #294

Closed
sdqali opened this issue Mar 24, 2018 · 1 comment · Fixed by #295
Closed

FreeBuilder should respect @JacksonXmlProperty annotations #294

sdqali opened this issue Mar 24, 2018 · 1 comment · Fixed by #295
Labels
enhancement

Comments

@sdqali
Copy link
Contributor

sdqali commented Mar 24, 2018

Jackson allows methods to be serialized to and de-serialized from different XML and JSON representations by using a combinations of the @JsonProperty and @JacksonXmlProperty annotations.
Currently, FreeBuilder looks for only @JsonProperty and adds them to the result.
This makes FreeBuilder unsuitable for situations where a class need to have different XML and JSON representations.
@sdqali
Copy link
Contributor Author

sdqali commented Mar 26, 2018

@ChrisAlice I have a patch that addresses this. I will submit it once I have confirmed that I can sign the CLA.

sdqali added a commit to sdqali/FreeBuilder that referenced this issue Mar 28, 2018
@sdqali
inferred#294 - Retain @JacksonXmlProperty annotations present on acce…
2062cd4 
…ssor methods.

Use common assert method for all Jackson annotations
@sdqali sdqali mentioned this issue Mar 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass through @JacksonXmlProperty annotations sdqali/FreeBuilder
2 participants
@sdqali @alicederyn