Skip to content

Conversation

@CyberShadow
Copy link
Contributor

Thank you for this very nice tool!

Here are some lexer improvements that fix some mismatched coverage in my project.

You are right, though, this is pushing the limits of what regular expressions can do. Adding a proper lexer, or reusing one from bash itself or shellcheck should result in more accurate results.

@coveralls
Copy link

coveralls commented Feb 21, 2018

Coverage Status

Coverage increased (+0.006%) to 99.038% when pulling bab65d8 on CyberShadow:lexer-fixes into 4d00d47 on infertux:master.

@infertux infertux merged commit a9deeed into infertux:master Mar 1, 2018
@infertux
Copy link
Owner

infertux commented Mar 1, 2018

Thank you very much for those (horrible) regexps ;)

Do you need me to push a new release with that fix to rubygems.org?

[References #25]

@infertux
Copy link
Owner

infertux commented Mar 1, 2018

Nevermind, I just pushed release 1.8.1 with your fix. Thanks again.

@CyberShadow
Copy link
Contributor Author

Thanks! That bumped my coverage by an entire 1.4% :)

@infertux
Copy link
Owner

infertux commented Mar 2, 2018

aconfmgr looks pretty cool. I'll give it a try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants