Cédric Félizard infertux

Organizations

@enspiral @Ung-UTT @buckybox
infertux commented on pull request infertux/bashcov#10
@infertux

Just wanted to add that this is great work @smspillaz and I don't mean to scare you away with my comments :stuck_out_tongue_closed_eyes:. I'm just trying to do cross-compatibil…

infertux commented on pull request infertux/bashcov#10
@infertux

Here's an excerpt of the man of GNU find: -perm -mode All of the permission bits mode are set for the file. Symbolic modes are accepted in this fo…

infertux commented on pull request infertux/bashcov#10
@infertux

Do you really need that? What about let(:runner) { Bashcov::Runner.new "bash #{test_suite}" }?

infertux commented on pull request infertux/bashcov#10
@infertux

I'm not a big fan of including mkmf here - it's supposed to be used in Makefile scripts and the like but not in "normal" Ruby code. If you look here

infertux commented on pull request infertux/bashcov#9
@infertux

Ok so this is quite interesting but before I comment on your PR, please help to understand how this is supposed to work. I pulled in this patch loc…

@infertux
@infertux
  • @infertux 4803ca5
    Add link to reset forgotten password
@infertux master is now 7ae07e4
@infertux
  • @infertux 36999f4
    Don't install puma from application Gemfile by default
@infertux
  • @infertux 7ae07e4
    Remove duplicated label key
@infertux
@infertux
  • @infertux 26ae0eb
    Handle case when extras is nil
@infertux
  • @infertux 09b7a8f
    Make sure the discount is a string
@infertux
@infertux
@infertux
  • @infertux b28ee14
    Don't return HTTP 500 for invalid web stores
@infertux
@infertux
@infertux
@infertux
  • @infertux dc75b16
    Respect 80 character rule