Skip to content

Conversation

@rigazilla
Copy link
Contributor

added method and a little fix

@mgencur
Copy link
Contributor

mgencur commented Jun 23, 2016

Can you add a simple test, please?

@infinispanrelease
Copy link

SUCCESS - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL Build 637 for 8113c4d
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:05:41

@infinispanrelease
Copy link

SUCCESS - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 Build 498 for 8113c4d
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:07:29

@infinispanrelease
Copy link

SUCCESS - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL Build 641 for 8113c4d
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:05:45

@infinispanrelease
Copy link

SUCCESS - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 Build 504 for 8113c4d
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:07:32

@infinispanrelease
Copy link

SUCCESS - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL Build 648 for 6182f02
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:05:47

@infinispanrelease
Copy link

SUCCESS - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 Build 513 for 6182f02
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:09:04

@rvansa
Copy link
Member

rvansa commented Jul 8, 2016

No objections, seems like just following the principle set up in the original implementation. Is there a test for goAsync?

@rigazilla
Copy link
Contributor Author

@rvansa In the Simple.cpp file there's a test for the get/put Async that generates the code from the goAsync template.

@mgencur with the last commit I'm counting 19 Async methods. If we want a test for each ones I think it's better to track this as a separate issue.

@rvansa
Copy link
Member

rvansa commented Jul 8, 2016

OK, I am content with this PR.

@slaskawi
Copy link
Contributor

Looks good to me!

@tristantarrant
Copy link
Member

Pushed to master, thanks

@rigazilla rigazilla deleted the HRCPP-278/removeWithVer branch October 12, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants