Hrcpp 286/failover #232
Closed
Hrcpp 286/failover #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigazilla
force-pushed
the
HRCPP-286/failover
branch
from
47f720f to
96de864
Compare
| throw; // Rethrow. The exception is rethrown as const! | ||
| void logErrorAndThrowExceptionIfNeeded(int& retryCount, const HotRodClientException& e) { | ||
| if (retryCount >= transportFactory->getMaxRetries() - 1) { | ||
| if (transportFactory->switchOnFailoverCluster() == ClusterStatus::SWITCHED) |
Contributor
There was a problem hiding this comment.
Formatting seems to be wrong here..
Contributor
|
Only some really small formatting issues found. Otherwise looks good to me. |
rigazilla
force-pushed
the
HRCPP-286/failover
branch
4 times, most recently
from
56e9e2f to
793bafb
Compare
rigazilla
force-pushed
the
HRCPP-286/failover
branch
from
793bafb to
c278c3d
Compare
| socketTimeout(_socketTimeout), sslConfiguration(_sslConfiguration),tcpNoDelay(_tcpNoDelay), | ||
| valueSizeEstimate(_valueSizeEstimate), maxRetries(_maxRetries), balancingStrategyProducer(bsp) {} | ||
|
|
||
| Configuration(const std::string &_protocolVersion, |
Member
There was a problem hiding this comment.
I think the other constructor can be removed, since the builder will use this one now ?
Member
|
A test is missing. Would it be possible to re-use one from the Java testsuite, as the setup is fairly complex ? |
Contributor
Author
|
@tristantarrant seems possible to re-use the java testsuite, I'm working on it |
rigazilla
force-pushed
the
HRCPP-286/failover
branch
5 times, most recently
from
b025049 to
30d38fd
Compare
Contributor
Author
|
@tristantarrant I changed the PR. Now the feature should be equivalent to the java one:
|
| ServerConfigurationBuilder& addServer() { | ||
| if (m_serversMap.find("DEFAULT_CLUSTER_NAME")== m_serversMap.end()) | ||
| { | ||
| m_serversMap["DEFAULT_CLUSTER_NAME"]; |
Member
There was a problem hiding this comment.
can DEFAULT_CLUSTER_NAME be constified?
Member
|
It looks great now, just a minor request |
rigazilla
force-pushed
the
HRCPP-286/failover
branch
from
30d38fd to
2cce844
Compare
Member
|
Pushed to master, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the client cross cluster failover