ISPN-3498 Cannot construct org.infinispan.util.KeyValuePair as it does n... #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.io.ObjectInput; | ||
| import java.io.ObjectOutput; | ||
| import java.io.OutputStream; | ||
| import java.io.Serializable; | ||
|
|
||
| /** | ||
| * A dummy marshaller impl that uses object streams converted via XStream as current JBoss Marshalling implementation |
There was a problem hiding this comment.
This doesn't use XStream any longer
There was a problem hiding this comment.
removed the reference to xstream
|
I've only spotted two unused imports. Everything else looks fine to me. |
| @@ -150,7 +152,10 @@ public void testRestrictionOnAddingToAsyncQueue() throws Exception { | |||
| } | |||
|
|
|||
| private TestObjectStreamMarshaller marshaller() { | |||
| return testObjectStreamMarshaller; | |||
| if (marshaller == null) { | |||
There was a problem hiding this comment.
Is there a reason this class is doing this through lazy initialization instead of a BeforeMethod/BeforeTest like the other classes?
There was a problem hiding this comment.
no reason but the fact that there was no @BeforeMethod annotated method present already. I've created one as obviously this approach raises questions for the readers of the class.
|
Pulling. |
…s not have a no-args constructor * an JBossMarshaller is built under the hood for each TestObjectStreamMarshaller instance * users need to call TestObjectStreamMarshaller.stop explicitly
|
Integrated, Thanks @mmarkus ! |
|
Sorry closed too early. |
|
Integrated this time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-3498