Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-4113 Introduce a rawValues configuration property for the RestStore #2439

Conversation

tristantarrant
Copy link
Member

ISPN-4113 Introduce a rawValues configuration property for the RestStore to tell it not to marshall/unmarshall data (in the context of Rolling Upgrades)

https://issues.jboss.org/browse/ISPN-4113

@pruivo
Copy link
Member

pruivo commented Mar 14, 2014

comments:

  • why no parser?
  • why no test?

@tristantarrant
Copy link
Member Author

Good questions: for the parser I want to wait for Galder'z XML rehaul, so I will create a separate issue.
As for the test: it is currently implicitly tested: the old behaviour (rawValues=false aka marshalling) is what is being tested by the standard cachestore tests.
The new behaviour (rawValues=true) is exercised by the rolling upgrades. I will extend this test to include a few more variants in datatypes (appplication/xml, application/octet-stream, etc)

@tristantarrant
Copy link
Member Author

Added the server integration tests developed my @mgencur
Added https://issues.jboss.org/browse/ISPN-4136 to track work for the XML parser

@pruivo
Copy link
Member

pruivo commented Mar 20, 2014

pulling...

@pruivo
Copy link
Member

pruivo commented Mar 20, 2014

@tristantarrant got this errors: https://gist.github.com/pruivo/56ec5e6927daf9fe734f
is it related to your PR?

@wburns
Copy link
Member

wburns commented Mar 20, 2014

@pruivo No this is fixed by #2455, it needs to be pulled in before any other JIRA.

+ ", port=" + port + ", path=" + path + ", appendCacheNameToPath=" + appendCacheNameToPath + ", " + super.toString() + "]";
return "RestStoreConfiguration [connectionPool=" + connectionPool + ", key2StringMapper=" + key2StringMapper
+ ", metadataHelper=" + metadataHelper + ", host=" + host + ", port=" + port + ", path=" + path
+ ", appendCacheNameToPath=" + appendCacheNameToPath + ", rawValues=" + rawValues + ", toString()="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the toString()= in here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally miss that... your lucky is that the testsuite takes year to run :D

tristantarrant and others added 2 commits March 20, 2014 15:48
…ore to tell it not to marshall/unmarshall data (in the context of Rolling Upgrades)
@tristantarrant
Copy link
Member Author

fixed and repushed

@wburns
Copy link
Member

wburns commented Mar 20, 2014

Looks good to me, assuming tests pass :)

@pruivo
Copy link
Member

pruivo commented Mar 20, 2014

integrated! thanks @tristantarrant !

@pruivo pruivo closed this Mar 20, 2014
@tristantarrant tristantarrant deleted the ISPN-4113/reststore_rawvalues branch May 6, 2015 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants