ISPN-3950 Allow deployment of event filters and converters in server #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public void undeploy(DeploymentUnit context) { | ||
| // TODO: Customise this generated block |
There was a problem hiding this comment.
Customise it by removing it :)
|
Needs rebase |
|
Rebased |
| context.addStep(new AbstractDeploymentChainStep() { | ||
| protected void execute(DeploymentProcessorTarget processorTarget) { | ||
| processorTarget.addDeploymentProcessor(Constants.SUBSYSTEM_NAME, | ||
| Phase.INSTALL, Constants.INSTALL_FILTER_FACTORY, new FilterFactoryExtensionProcessor(hotRodServerServiceName)); |
There was a problem hiding this comment.
If you have multiple endpoints enabled, this fails with
java.lang.IllegalStateException: JBAS018786: Multiple deployment unit processors registered with priority 6145 and class class org.infinispan.server.endpoint.deployments.FilterFactoryExtensionProcessor
So probably the deployer should be installed independently and added as a dependency.
There was a problem hiding this comment.
This is not straightforward to solve.
* Moved to core/ to make it easier for users to implement factory instances and avoid leaking server/hotrod components.
* Adding filters and converters done dynamically now, to make it easier to deal with deployments of these. * Servlet deployment disabled for HotRod tests in server because it forces deployment jars to be included within war. Instead, use JMX deployment. * Updated documentation to reflect how filter and converter instances are plugging into Infinispan Server.
|
Closing for the time being. |
|
New PR: #2782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-3950
A long awaited PR completing functionality in Hot Rod event (barring some small fixes) by allowing filter and converter instances to be deployed in Infinispan Servers. Adding filters and converters is a dynamic process now to make it easier to fit into the deployment model.
This PR also includes refactoring of filter and converter factory classes to
coremodule, as agreed on a dev discussion.