Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-5048 Clean up uberjars to remove javax.* classes and relocated imported classes which don't affect API #3136

Conversation

@ghost

This comment has been minimized.

Copy link

ghost commented Dec 4, 2014

Looking.

<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
<exclude>META-INF/ASL2.0</exclude>
<exclude>META-INF/DEPENDENCIES</exclude>

This comment has been minimized.

Copy link
@ghost

ghost Dec 4, 2014

DEPENDENCIES.txt should be excluded as well (currently the one from infinispan-commons is included).
LICENSE.txt is not present at all

The correct DEPENDENCIES.txt and LICENSE.txt can be included using the maven-bundle-plugin by using an Include-Resource instruction similar to the one used for the blueprint.xml

The same issue for remote and embedded-query and the change is not applied to the cli uberjar.

@tristantarrant tristantarrant force-pushed the tristantarrant:ISPN-5048/uberjar_pollution branch from 4220c28 to fe47c8c Dec 5, 2014
…mported classes which don't affect API
@tristantarrant tristantarrant force-pushed the tristantarrant:ISPN-5048/uberjar_pollution branch from fe47c8c to ed15395 Dec 5, 2014
@tristantarrant

This comment has been minimized.

Copy link
Member Author

tristantarrant commented Dec 5, 2014

Applied the filter to cli as well. Remove DEPENDENCIES.txt and also remove the hotrod client from infinispan-embedded (it was being pulled in by the remote cachestore). If a user wants to use that they need infinispan-remote as well.

@ghost ghost added Needs Rebase and removed Ready for Review labels Dec 5, 2014
@ghost

This comment has been minimized.

Copy link

ghost commented Dec 5, 2014

Integrated into master. 7.0.x needs rebase.

@tristantarrant

This comment has been minimized.

@ghost

This comment has been minimized.

Copy link

ghost commented Dec 10, 2014

Integrated in 7.0.x also. Thanks @tristantarrant !

@ghost ghost closed this Dec 10, 2014
@tristantarrant tristantarrant deleted the tristantarrant:ISPN-5048/uberjar_pollution branch Jan 12, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.