Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-6029 DDL for JDBC store tables should never allow null #5001

Merged
merged 1 commit into from Mar 24, 2017

Conversation

ryanemerson
Copy link
Contributor

Copy link
Member

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, just waiting on CI results. Those pesky IT tests :P

@wburns
Copy link
Member

wburns commented Mar 24, 2017

Hrmm it seems a lot of tests are only failing in this branch, which seems quite odd to me [1].

[1] http://ci.infinispan.org/viewLog.html?buildId=53415&buildTypeId=bt9

Going to force another run of this PR.

@danberindei
Copy link
Member

@wburns it's not just this branch, it's all the 8.2.x pull requests. The 8.2.x branch is in a pretty bad shape...

@wburns
Copy link
Member

wburns commented Mar 24, 2017

Ah yes 👎

@wburns
Copy link
Member

wburns commented Mar 24, 2017

Pulling... failures are unrelated.

@wburns wburns merged commit a20806f into infinispan:8.2.x Mar 24, 2017
@wburns
Copy link
Member

wburns commented Mar 24, 2017

Integrated into 8.2.x, thanks @ryanemerson and @pferraro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants