Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-7814 Remove protected cache security check #5206

Merged
merged 1 commit into from Jun 15, 2017

Conversation

@galderz
Copy link
Member

commented Jun 15, 2017

https://issues.jboss.org/browse/ISPN-7814

  • This check has proven to be not very effective.
  • Instead, a more comprehensive default security configuration is needed
    which is being worked on.
@tristantarrant

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

testNonLoopbackPutOnProtectedCache(org.infinispan.server.hotrod.HotRodSingleClusteredNonLoopbackTest) Time elapsed: 0.009 sec <<< FAILURE!
java.lang.ClassCastException: org.infinispan.server.hotrod.test.TestResponse cannot be cast to org.infinispan.server.hotrod.test.TestErrorResponse
at org.infinispan.server.hotrod.HotRodSingleClusteredNonLoopbackTest.testNonLoopbackPutOnProtectedCache(HotRodSingleClusteredNonLoopbackTest.java:76)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)

@galderz

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2017

Checking...

* This check has proven to be not very effective.
* Instead, a more comprehensive default security configuration is needed
  which is being worked on.
@galderz galderz force-pushed the galderz:t_7814 branch from 7b15047 to c02634a Jun 15, 2017
@galderz

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2017

@tristantarrant Should be fixed now

@tristantarrant tristantarrant added this to the 9.1.0.Beta1 milestone Jun 15, 2017
@tristantarrant tristantarrant merged commit 61b3d83 into infinispan:master Jun 15, 2017
1 check was pending
1 check was pending
continuous-integration/jenkins/pr-merge This commit is being built
Details
@tristantarrant

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

Pushed to 9.0.x too

@galderz galderz deleted the galderz:t_7814 branch Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.