Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-8379 Support configuration wildcards #5507

Merged
merged 1 commit into from Oct 24, 2017

Conversation

@galderz

This comment has been minimized.

Copy link
Member

galderz commented Oct 10, 2017

Looks good, couple of things:

  • What happens if multiple cache templates match a cache name requested by the user? We should specify that.
  • The documentation needs to indicate what happens when a user requests a cache that does not exist and it matches an existing template.
@tristantarrant tristantarrant force-pushed the tristantarrant:ISPN-8379/wildcards branch from d22004b to 031a68d Oct 20, 2017
@tristantarrant tristantarrant force-pushed the tristantarrant:ISPN-8379/wildcards branch from 031a68d to fe2874c Oct 20, 2017
@tristantarrant

This comment has been minimized.

Copy link
Member Author

tristantarrant commented Oct 20, 2017

@galderz now it throws an exception when there are multiple wildcard matches. I've also added additional information about retrieving undefined caches.

@wburns
wburns approved these changes Oct 24, 2017
Copy link
Member

wburns left a comment

Changes look fine to me, any more comments or questions @galderz ?

@galderz

This comment has been minimized.

Copy link
Member

galderz commented Oct 24, 2017

Looks good! Remember to blog after alpha1 goes out ;)

@galderz galderz merged commit 5eb3f2b into infinispan:master Oct 24, 2017
1 check failed
1 check failed
continuous-integration/jenkins/pr-head This commit has test failures
Details
@tristantarrant tristantarrant deleted the tristantarrant:ISPN-8379/wildcards branch Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.