ISPN-8695 Create remote caches using the XML configuration #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build timeout, retriggering... |
gustavocoding
suggested changes
Jan 20, 2018
| * | ||
| * @param name the name of the cache to create | ||
| * @param configuration a concrete configuration that will be sent to the server. The XML representation of this | ||
| * configuration must be in a format supported by the server. |
There was a problem hiding this comment.
It's not clear what is the XSD of the configuration that must be passed in. Is it urn:infinispan:config:9.2 (embedded) or urn:infinispan:server:core:9.2 (server)? To avoid any doubt, I think we should mention in the javadoc
There was a problem hiding this comment.
I'd really like to have a common schema which is then xincluded into the two subschemas (embedded and server) which can then add their own idiosyncrasies. But at the moment this is the embedded schema.
There was a problem hiding this comment.
that's fine, IMO we should just mention that in the javadoc
tristantarrant
force-pushed
the
ISPN-8695/remote_createcache_full_config
branch
from
6a6a731
to
bafa7e2
Compare
|
@gustavonalle Updated the javadoc as requested |
gustavocoding
approved these changes
Jan 29, 2018
|
Merged, thanks @tristantarrant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-8695