DistSyncTxL1FuncTest.testGetBlockingAnotherGetCacheEntry random failures #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getAsync() doesn't always run interceptor callbacks on a separate thread. The remote get can finish before the calling thread calls thenAccept(), especially when the test suite is limited to a single CPU.
wburns
reviewed
Jan 31, 2018
| @@ -57,7 +57,7 @@ | |||
| boolean isSatisfied() throws Exception; | |||
| } | |||
|
|
|||
| protected static final Log log = LogFactory.getLog(MethodHandles.lookup().lookupClass()); | |||
| protected final Log log = LogFactory.getLog(getClass()); | |||
There was a problem hiding this comment.
Hrmm is this an issue with the other JIRA that changed this @tristantarrant ?
There was a problem hiding this comment.
@wburns The problem is that logs of tests use the inherited field, and their messages end up logged with the AbstractInfinispanTest category. I initially wanted to make it private static, but there were too many tests using it and I wouldn't have been able to sneak it into this PR that way :)
danberindei
force-pushed
the
ISPN-8742_DistSyncTxL1FuncTest
branch
from
adee9c3
to
59c095a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-8742
getAsync() doesn't always run interceptor callbacks on a separate thread.
The remote get can finish before the calling thread calls thenAccept(),
especially when the test suite is limited to a single CPU.
The fix is trivial, figuring how the next test was affected took me much longer :)