Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-9489 Adds missing compute family lifespan methods #6271

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@karesti
Copy link
Contributor

commented Sep 24, 2018

@karesti karesti added this to the 9.4.0.Final milestone Sep 24, 2018

@karesti

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2018

@danberindei I changed the java doc as you said in the other issue

@karesti karesti force-pushed the karesti:ISPN-9489 branch from 2a28342 to e6c661e Sep 24, 2018

@karesti karesti force-pushed the karesti:ISPN-9489 branch from e6c661e to 85e4d86 Sep 25, 2018

};
}

;

This comment has been minimized.

Copy link
@tristantarrant

tristantarrant Sep 25, 2018

Member

what did this semicolon do to you ? :)

This comment has been minimized.

Copy link
@tristantarrant

tristantarrant Sep 25, 2018

Member

Remove it completely

This comment has been minimized.

Copy link
@karesti

karesti Sep 25, 2018

Author Contributor

ops

@karesti karesti force-pushed the karesti:ISPN-9489 branch from 85e4d86 to abc3f1c Sep 25, 2018

@karesti

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2018

test failures not related

@danberindei
Copy link
Member

left a comment

Looks good Katia, one minor comment

@Inject
private GlobalConfiguration globalCfg;
@Inject
private LocalTopologyManager localTopologyManager;

This comment has been minimized.

Copy link
@danberindei

danberindei Sep 26, 2018

Member

I'm not a big fan of @Inject on the same line, but since we're already doing it everywhere else, we shouldn't change it here.

@karesti karesti force-pushed the karesti:ISPN-9489 branch from abc3f1c to 1dc8d50 Sep 26, 2018

@karesti

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2018

@danberindei danberindei merged commit db6378f into infinispan:master Sep 26, 2018

1 check failed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
@danberindei

This comment has been minimized.

Copy link
Member

commented Sep 26, 2018

Thanks Katia, integrated!

@karesti karesti deleted the karesti:ISPN-9489 branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.