Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-10224 Fix session protection #7025

Merged
merged 2 commits into from Jun 19, 2019

Conversation

karesti
Copy link
Contributor

@karesti karesti commented Jun 10, 2019

@karesti karesti changed the title Fix session protection ISPN-10224 Fix session protection Jun 10, 2019
@karesti karesti force-pushed the fix-session-protection branch 3 times, most recently from ecbd11b to e484e00 Compare June 11, 2019 09:57
@karesti karesti added Urgent! and removed Preview labels Jun 11, 2019
Copy link
Member

@danberindei danberindei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have liked a separate JIRA+commit for adding the SKIP_LISTENER_NOTIFICATION flag, otherwise it looks good.

@@ -66,6 +66,23 @@ public void testEventBridge() throws Exception {
EventsWaiter.assertSessionContent(() -> eventsCollector.getEvents(), SessionDeletedEvent.class, sessionToBeDeleted.getId(), "foo", "bar", 2, TimeUnit.SECONDS);
}

@Test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wburns here

@karesti
Copy link
Contributor Author

karesti commented Jun 19, 2019

@danberindei already been backported

@ryanemerson ryanemerson merged commit 4b381c5 into infinispan:master Jun 19, 2019
@karesti karesti deleted the fix-session-protection branch June 19, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants