Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-10450 Improve the initial ServerNG experience (and other assorted stuff) #7174

Merged

Conversation

@tristantarrant
Copy link
Member

tristantarrant commented Jul 30, 2019

ISPN-10450 Improve the initial ServerNG experience
* Localizable help messages for server and user-tool
* Stack selection via the command-line (-j)
* Port binding via the command-line (-p)
* Make default configuration (infinispan.xml) clustered
* Add non-clustered configuration infinispan-local.xml
* Disable TLS/keystore and memcached connector in default config
* Refactor shells scripts extracting common logic to common.sh
* Ensure that it is possible to start the server from paths with spaces
* Add a README.md file to get users started
https://issues.jboss.org/browse/ISPN-10450
https://issues.jboss.org/browse/ISPN-10434

ISPN-10449 Detect empty properties realm
* Refactor security realm configuration
https://issues.jboss.org/browse/ISPN-10449

ISPN-10448 ServerNG Licenses
https://issues.jboss.org/browse/ISPN-10448

@tristantarrant

This comment has been minimized.

Copy link
Member Author

tristantarrant commented Jul 30, 2019

Failures are unrelated

@ryanemerson ryanemerson self-requested a review Jul 31, 2019
Copy link
Contributor

ryanemerson left a comment

The placeholders in README and copyright are not being replaced as we don't have resources defined in the pom's build.

@ryanemerson

This comment has been minimized.

Copy link
Contributor

ryanemerson commented Jul 31, 2019

Also, the licenses aren't included in the distribution so the licenses.html "Local License" column links always result in a 404.

@tristantarrant

This comment has been minimized.

Copy link
Member Author

tristantarrant commented Aug 1, 2019

@ryanemerson the actual licenses should be added in the distribution module, but I cannot test the thing because it is currently broken by the javadoc / protostream interaction

* Localizable help messages for server and user-tool
* Stack selection via the command-line (-j)
* Port binding via the command-line (-p)
* Make default configuration (infinispan.xml) clustered
* Add non-clustered configuration infinispan-local.xml
* Disable TLS/keystore and memcached connector in default config
* Refactor shells scripts extracting common logic to common.sh
* Ensure that it is possible to start the server from paths with spaces
* Add a README.md file to get users started
* Refactor security realm configuration
@tristantarrant tristantarrant force-pushed the tristantarrant:ISPN-10450/serverng_initial branch from e215513 to c05b386 Aug 1, 2019
@tristantarrant

This comment has been minimized.

Copy link
Member Author

tristantarrant commented Aug 1, 2019

@ryanemerson I have added filtering for the server resources.

@ryanemerson

This comment has been minimized.

Copy link
Contributor

ryanemerson commented Aug 1, 2019

@ryanemerson the actual licenses should be added in the distribution module, but I cannot test the thing because it is currently broken by the javadoc / protostream interaction

Ok, the protostream PR needs more tweaks still, so merging as is and we can revisit if required.

@ryanemerson ryanemerson merged commit 0ed28f5 into infinispan:master Aug 1, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-head This commit has test failures
Details
@tristantarrant tristantarrant deleted the tristantarrant:ISPN-10450/serverng_initial branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.