New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-13181 JDK 17 changes (Nashorn) #9450
ISPN-13181 JDK 17 changes (Nashorn) #9450
Conversation
I'll add JDK 17 to the CI slaves as soon as PSI comes back from the dead... |
https://ci.infinispan.org/job/InfinispanAlternateBuilds/job/InfinispanJDKLatest/ is running against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine, however CI is still failing. https://ci.infinispan.org/job/InfinispanAlternateBuilds/job/InfinispanJDKLatest/80/
Because that CI job is running against |
224a7b9
to
6703923
Compare
It looks like Nashorn needs to be added to the client classpath for tests. There are also various IT failures. |
6703923
to
d6586f3
Compare
d6586f3
to
8064a5f
Compare
Further changes required. 74 failures atm. |
25e8bea
to
a3dabf6
Compare
Please ignore the |
2ddbb0c
to
f83fd5c
Compare
This is good to go. Before merging I need to remove the commit that modifies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor things, but it should be ok to remove the Jenkins commit and merge if the normal CI run is fine.
@@ -191,6 +193,7 @@ public void testScriptUpload() { | |||
|
|||
@Test | |||
public void testExecScripts() { | |||
SkipJunit.skipSinceJDK(16); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we still need to test this functionality with 17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the nashorn dependencies will force us to run all these tests in Container mode, but we don't have a JDK 17 container yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I've created ISPN-13269 so this isn't missed.
...iver/core/src/main/java/org/infinispan/server/test/core/ContainerInfinispanServerDriver.java
Outdated
Show resolved
Hide resolved
Also, I think ISPN-13182 is the wrong Jira ID as that has already been resolved and relates to blockhound. |
f83fd5c
to
7e15e56
Compare
Also, shouldn't the |
I did not modify the Jenkinsfile yet |
Argh sorry, I should have explicitly checked that! I just saw that the number of commits had reduced and assumed. |
I have added a commit which fixes the NPE in |
Once CI is done I'll remove the Jenkinsfile commit |
5db0805
to
c506e60
Compare
@ryanemerson I've repushed it without the Jenkinsfile change |
There's a |
c506e60
to
db1bf22
Compare
Fixed |
@ryanemerson lgtm |
Could you squash the NPE commits into ISPN-13181.
This also needs addressing. |
db1bf22
to
f5179ec
Compare
Silly me: I had made a change to the default |
f5179ec
to
72b5b53
Compare
I created an extra Jira and squashed the NPE commits |
The four |
* Use the standalone Nashorn dependency * Run relevant server tests in container
* Upgrade XOM as a Workaround for Galleon plugin * Use WildFly 24.0.1
72b5b53
to
d45462d
Compare
The arquillian upgrade has changed the class of the ConsoleConsumer thread. I've fixed it |
Thanks @tristantarrant |
There was a possible related failure in org.infinispan.server.functional.RollingUpgradeDynamicStoreCliIT.testRollingUpgrade |
https://issues.redhat.com/browse/ISPN-13181
https://issues.redhat.com/browse/ISPN-13272