This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Fix api-problem's translation of 404 errors #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
|
I like it when a 2 line code change is accompanied by 11 new tests. 😆 So good. |
infinitered-circleci
pushed a commit
that referenced
this pull request
Jan 15, 2019
## [2.0.3](v2.0.2...v2.0.3) (2019-01-15) ### Bug Fixes * **api:** Add 404 error translation ([#141](#141)) by [@bryanstearns](https://github.com/bryanstearns) ([0369a23](0369a23))
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My project’s API started 404ing today, causing me to notice that the boilerplate
getGeneralApiProblem()doesn’t correctly translate 404 errors.I added a test for all of its translations, made the test pass, and copied the test to this project… and noticed that we don’t have a test that ensures that new apps’ tests pass, so I added that too. (Surprisingly, it doesn’t seem to add to the test time, because of jest’s parallelism? — tests still take about 320s on my machine. 🎉 )