Folder restructure AKA "The Flattening"

[robinheinze]

This will be for version 3.0

In this new structure, screens will still be in folders co-located with any assets, but components will all live under /components, even if they are specific to a screen. Storybook and assets will also still be co-located with each component. We would also remove the concept of “domain” from the generators, which should make things a bit clearer.

Note: This is the top level directory. We removed ./src/app and all of the actual app content now lives under simply ./app. The rest of the top level directory is unchanged and still contains ios, android, ignite, storybook, and test directories.

app/
  components/
    text-field/
      index.ts
      text-field.tsx
      text-field.story.tsx
      text-field.props.ts
  i18n/
  models/
      root-store/
        setup-root-store.ts
  navigation/
  screens/
    first-example-screen/
      first-example-screen.tsx
      bowser.png
      bowser@2x.png
      index.ts
  services/
    api/
    reactotron/
  theme/
    fonts/
    color.ts
    spacing.ts
    typography.ts
    index.ts
  utils/
    validate.ts
    keychain.ts
    delay.ts
    storage/
  app.tsx (formerly root-component.tsx and main.tsx. Includes storybook conditional)
  environment-variables.ts

Biggest differences

• Changed the top-level app folder from ./src to ./app. For the files that were previously in ./src/app:
  • Consolidated main.tsx and root-component.tsx into one app.tsx which lives at the root of ./app
  • Moved setup-root-store.ts into ./app/models/root-store/
• Split ./src/views into ./app/screens and ./app/components. Screen and component generators will place all new components and screens in these two folders.
• Renamed ./lib to ./utils
• Removed the "domain" logic from all of the generators

[jamonholmgren]

A few minor things, but otherwise this looks 🥇 fantastic 🥇

[jamonholmgren]

I merged @bryanstearns 's PR #141 which introduced conflicts to this one, apologies @robinheinze .

[guhungry]

I don't know if off topic. But, will this pr break old project if i update boilerplate to this version?

[robinheinze]

@guhungry The only thing I can think of would be generators trying to place files in directories that don't exist. I will make sure it creates the directory if it doesn't find it. Thanks for noticing that!

[robinheinze]

@guhungry Just verified that the generators are all backwards compatible, so I don't believe anything will break if you were to update the boilerplate to this version in an existing project. You can always pin the version though if you'd like to keep using the old structure.

[guhungry]

@robinheinze Thanks. Sorry fore more question. How about ignite generate screen some-new, Can it add new screen to navigation correctly? (For existing project)

[robinheinze]

@guhungry I think it might have trouble with that, but I haven't verified for sure. In general, some things may work, but we really aren't guaranteeing backwards compatibility with a major version bump like this (this will be 3.0.0). The safest thing to do if you have an existing project is to pin your boilerplate version to 2.0.3 (although I think NPM/Yarn should keep you safe from automatic major version upgrades anyway).

[infinitered-circleci]

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[jamonholmgren]

Gah, why ... why .... 😦 I'll fix

[mangei]

two slashes typo

[jamonholmgren]

@mangei Would you mind sending in a PR?

[addingama]

@jamonholmgren #160

[mangei]

I just read this. Thanks @dashracer for fixing it! :)