This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Remove "extras" from generated component #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 3, 2018 16:58
robinheinze
approved these changes
Oct 4, 2018
templates/component.tsx.ejs
Outdated
|
|
||
| return ( | ||
| <TouchableOpacity style={viewStyle} {...rest}> | ||
| <TouchableOpacity style={style} {...rest}> |
There was a problem hiding this comment.
My inclination is to make this a straight up <View> and lose the extends TouchableOpacityProperties in the props above, but my GAFO is relatively low if others want to keep it.
|
@robinheinze I went with your suggestion because my GAFO is zero. |
# Conflicts: # boilerplate/test/__snapshots__/storyshots.test.ts.snap
robinheinze
approved these changes
Oct 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
Demo:
(The word "Tea" is the generated component)
