Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Switch example API to from GitHub to Typicode JSON example api #98

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

robinheinze
Copy link
Member

@robinheinze robinheinze commented Sep 18, 2018

This is for #92

Quote for convenience:

"Github has a really great, robust REST API.

However, it doesn't feel like it makes the most ideal example API for Ignite.

- Repos aren't super relatable as a data type, compared to, say, users
- It has some custom configuration, like it's custom Content-Type: application/vnd.github.v3+json which can be confusing if you're trying to transform our example into your own API service .

I'm proposing switching the sample API to https://jsonplaceholder.typicode.com/, which is designed to be a sample, and supports straight REST endpoints for data types like users, todos, posts and other familiar example concepts."

screen shot 2018-09-18 at 2 30 30 pm

Copy link
Contributor

@skellock skellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx Robin

@skellock skellock merged commit af09237 into master Sep 19, 2018
@skellock skellock deleted the example-api branch September 19, 2018 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants