fix: 2234 - Remove SafeAreaView in favor of useSafeAreaInsets hook #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlinisaacson
changed the title
frankcalise
approved these changes
Oct 3, 2022
jamonholmgren
approved these changes
Oct 4, 2022
Co-authored-by: Jamon Holmgren <jamonholmgren@gmail.com>
infinitered-circleci
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [8.2.2](v8.2.1...v8.2.2) (2022-10-04) ### Bug Fixes * Remove SafeAreaView in favor of useSafeAreaInsets hook ([#2238](#2238)) ([813c34e](813c34e))
|
🎉 This PR is included in version 8.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
There is an issue with the SafeAreaView from react-native-safe-area-context that causes the top inset to not be set on first render. So you see the content, then it re-renders and jumps down to it's final resting place. The fix is to not use SafeAreaView and use the useSafeAreaInsets hook instead.
This PR changes the Screen component to use the hook and apply the insets as screen padding if they are passed in, which fixes #2234.
Old behavior
old-behavior.MP4
New (fixed) behavior
new-behavior.MP4
Multiple edges passed in (top and bottom)
Ugly, but it shows it still works