Ignite basic structure #577

Merged
merged 11 commits into from Jan 3, 2017

Projects

None yet

2 participants

@GantMan
Member
GantMan commented Jan 3, 2017 edited

basic structure PR

comes with 2 command variations

./devignite add basic-structure
creates a minimal version of the Ignite structure

./devignite add basic-structure --unholy
creates the "KNOWN" ignite structure. For code crutches.

Motivation:

As modules are made, unholy should be subtracted from. The goal is to subtract unholy down to being a mirror of basic-structure, and thus deleting itself.

Pertains to:

Closes: #568
Crucial for #567

@GantMan GantMan requested review from skellock and kevinvangelder Jan 3, 2017
@skellock

Let's address the --min missing themeing and this will be good.

+ if (__DEV__) {
+ // If ReactNative's yellow box warnings are too much, it is possible to turn
+ // it off, but the healthier approach is to fix the warnings. =)
+ console.disableYellowBox = !DebugSettings.yellowBox
@skellock
skellock Jan 3, 2017 Member

Should this be reading from the DebugConfig?

@GantMan
GantMan Jan 3, 2017 Member

yes will fix

+ }
+
+ // Allow/disallow font-scaling in app
+ Text.defaultProps.allowFontScaling = AppConfig.allowTextFontScaling
@skellock
skellock Jan 3, 2017 Member

I had no idea you could do this!

+ container: {
+ flex: 1,
+ justifyContent: 'center',
+ backgroundColor: Colors.background
@skellock
skellock Jan 3, 2017 Member

We don't have Colors.background anymore. Same with fonts and margins.

@GantMan GantMan merged commit 178d29e into next Jan 3, 2017

1 check passed

semaphoreci The build passed on Semaphore.
Details
@GantMan GantMan deleted the ignite-basic-structure branch Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment