Adds ignite plugin path and improves ignite add support. #580

Merged
merged 3 commits into from Jan 4, 2017

Projects

None yet

2 participants

@skellock
Member
skellock commented Jan 4, 2017

This PR adds a round of fun to the ignite add command.

  • Gluegun now supports configurable template directories, so here's support for that + 1 example (vector-icons). Basic structure is next, but not part of this PR because I want to do something awesome with bulk template generation in gluegun.

  • Switched Shell.exec to context.system.run.

  • Added a switch called --npm to ignite add because yarn insists on validating existing modules against npm. Since ignite 2.0 isn't shipped, this blows up yarn. But not npm.

  • Adds better code docs inside the ignite gluegun plugin.

  • Adds support for ignite 3rd party folk to opt-in to react-native link and installing modules as dev dependencies.

  • Added some try/catches in order to centralize error messages.

@skellock skellock added this to the 2.0 milestone Jan 4, 2017
@skellock skellock self-assigned this Jan 4, 2017
@skellock skellock requested a review from GantMan Jan 4, 2017
@skellock skellock changed the title from Ignite plugin path to Adds ignite plugin path and improves ignite add support. Jan 4, 2017
if (ignite.useYarn) {
- Shell.exec(`yarn add ${moduleName} --dev`, {silent: true})
+ Shell.exec(`yarn add ${moduleName}`, {silent: true})
@GantMan
GantMan Jan 4, 2017 Member

"this doesn't look right" - Steve

@GantMan
GantMan Jan 4, 2017 Member

We should change this to also support the config flags. Should be dev dep by default.

@GantMan
GantMan Jan 4, 2017 Member

add comments plz, to make sure we stop getting confused here.

@GantMan GantMan merged commit 96e2f03 into next Jan 4, 2017

1 check passed

semaphoreci The build passed on Semaphore.
Details
@GantMan GantMan deleted the ignite-plugin-path branch Jan 4, 2017
@GantMan
Member
GantMan commented Jan 4, 2017

shit just got real - http://i.imgur.com/FpltJvO.gifv

@skellock
Member
skellock commented Jan 4, 2017

I lol'ed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment