Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align expander icons with mui #1131

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@RichiCoder1
Copy link
Contributor

RichiCoder1 commented Aug 20, 2019

This is actually different then what I suggested in #1130 and I'd happy to go with that change instead. This PR aligns the command panel with how Material actually does expansion panels, making the current closed Icon MdExpandMore (which was previously the open Icon), and makes the open Icon MdExpandLess.

Copy link
Collaborator

rmevans9 left a comment

LGTM

@rmevans9 rmevans9 merged commit 02de687 into infinitered:master Aug 28, 2019
1 check passed
1 check passed
ci/circleci: build_and_test Your tests passed on CircleCI!
Details
@RichiCoder1 RichiCoder1 deleted the RichiCoder1:RICHI/Expand_Collapse_UX branch Aug 28, 2019
infinitered-circleci pushed a commit that referenced this pull request Aug 28, 2019
## [2.17.1](v2.17.0...v2.17.1) (2019-08-28)

### Bug Fixes

* align expander icons with mui ([#1131](#1131)) ([02de687](02de687))
@infinitered-circleci

This comment has been minimized.

Copy link

infinitered-circleci commented Aug 28, 2019

🎉 This PR is included in version 2.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.