Don't access window if unavailable #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skellock
approved these changes
Mar 7, 2018
joshuayoes
pushed a commit
that referenced
this pull request
Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Jan 30, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson
pushed a commit
that referenced
this pull request
Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Reactotron with the Redux plugin in a React.js app with server side rendering.
The Redux store is configured on the client and on the server, however because reactotron-react-js attempts to access
windowon module import this fails server side. I don't plan to use Reactotron in production or on the server, but not being able to import the module at all during store configuration is problematic.I've just added a check for window as a straightforward solution, but understand that this might not be suitable depending on what else you plan to use the userAgent for.
Hope it's helpful.