New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for iPhone 5 pointers #209

Merged
merged 1 commit into from Mar 11, 2015

Conversation

Projects
None yet
4 participants
@GantMan
Member

GantMan commented Mar 11, 2015

currently spec fails for iPhone 5 rake spec device_name="iPhone 5" Color causes crashes on iPhone 5!

This fixes that.

@squidpunch

This comment has been minimized.

Show comment
Hide comment
@squidpunch

squidpunch Mar 11, 2015

Contributor

This is the same as #194, no?

Contributor

squidpunch commented Mar 11, 2015

This is the same as #194, no?

twerth added a commit that referenced this pull request Mar 11, 2015

@twerth twerth merged commit 6190bc2 into infinitered:master Mar 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Mar 11, 2015

Member

For the life of me I couldn't find the old one! AND I had a product in the wild that was crashing bc of this. The true credit belongs @mwise who wrote the same exact fix, HA!

I'm just happy it's fixed, honestly. If we need to re-modify the git history so mwise gets credit, I'd help.

Member

GantMan commented Mar 11, 2015

For the life of me I couldn't find the old one! AND I had a product in the wild that was crashing bc of this. The true credit belongs @mwise who wrote the same exact fix, HA!

I'm just happy it's fixed, honestly. If we need to re-modify the git history so mwise gets credit, I'd help.

@GantMan GantMan deleted the GantMan:fix_color_for_iphone5 branch Mar 11, 2015

@mwise

This comment has been minimized.

Show comment
Hide comment
@mwise

mwise Mar 11, 2015

Contributor

Ha, that's funny! I don't particularly care about the credit for the fix, I'm just glad to get the validation that the begin/rescue was a non-crazy way to address the issue.

Contributor

mwise commented Mar 11, 2015

Ha, that's funny! I don't particularly care about the credit for the fix, I'm just glad to get the validation that the begin/rescue was a non-crazy way to address the issue.

squidpunch pushed a commit to squidpunch/redpotion that referenced this pull request Mar 20, 2015

squidpunch pushed a commit to squidpunch/redpotion that referenced this pull request Mar 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment