Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: sonarcloud setup #331

Closed
wants to merge 18 commits into from

Conversation

gtoison
Copy link
Contributor

@gtoison gtoison commented Aug 27, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@szpak
Copy link
Contributor

szpak commented Aug 27, 2022

Too good to be true ;-).

@gtoison
Copy link
Contributor Author

gtoison commented Sep 1, 2022

Too good to be true ;-).

I finally got this to work by reusing the sonarcloud organization created a while ago: https://sonarcloud.io/summary/new_code?id=org.infinitest%3Ainfinitest-parent
The findings reported on the pull request are for the new code; I only updated the build so it did not find any new bugs :)
You can try merging the master into your spock2 pull request to see if it's working.

In the end the PR did not work because:

@gtoison gtoison closed this Sep 1, 2022
@szpak
Copy link
Contributor

szpak commented Sep 2, 2022

You can try merging the master into your spock2 pull request to see if it's working.

I will, once I solve the problem with classpath in class pool...

Secrets are not available to PR triggered from forked repos, it had to be done from a branch on this repo

It makes sense. At least for your own PRs you will be able to see the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants